ryujinx-archive/Ryujinx-Mako
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix KeyError when removing reviewers

Browse source
This commit is contained in:
TSRBerry 2023-09-13 23:51:23 +02:00 committed by TSR Berry
parent bbabbac209
commit 09cd87917d
No known key found for this signature in database
GPG key ID: 52353C0A4CCA15E2
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
ryujinx_mako/commands/update_reviewers.py
View file

@ -31,6 +31,19 @@ class UpdateReviewers(GithubSubcommand):
def reviewers_lower(self) -> list[str]:
return [x.lower() for x in self._reviewers]
def _remove_reviewer(self, reviewer: str):
reviewer_lower = reviewer.lower()
reviewer_element = None
for element in self._reviewers:
if element.lower() == reviewer_lower:
reviewer_element = element
break
if not reviewer_element:
raise KeyError(reviewer)
self._reviewers.remove(reviewer_element)
def add_reviewers(self, new_entries: list[str]):
for reviewer in new_entries:
if reviewer.startswith("@"):
@ -59,7 +72,7 @@ class UpdateReviewers(GithubSubcommand):
self.add_reviewers(config["default"])
if pull_request_author.lower() in self.reviewers_lower:
self._reviewers.remove(self.reviewers_lower.index(pull_request_author.lower()))
self._remove_reviewer(pull_request_author)
try:
reviewers = list(self._reviewers)