89cfd16c10
The API contract between GObject-Introspection and bindings is that functions returning transfer-none floating references pass a reference to the bindings that should be taken ownership of by sinking it. Not doing so is wrong and will lead to memory leaks or double frees. Previously we would not distinguish this case and simply increment the reference count. In addition we would then sink the floating reference when the Object.Raw field is set later for InitiallyUnowned subclasses. Remove that last part and instead check directly in Object.Raw.set if we get a floating reference and if so simply sink it here and take ownership of it. The general assumption of Object.Raw.set is that it gets passed a reference that it should take ownership of. So in summary: 1) GetObject() would only increase the reference count of unowned, non-floating references so that we own it. For unowned, floating references it assumes ownership of the reference. 2) Raw.set assumes ownership of the reference passed to it and if it happens to be a floating reference then it will first sink it. Also warn if we get a floating, owned reference passed to GetObject() as that case is not allowed by GObject-Introspection and would cause the reference to be leaked. This fixes a memory leak with functions returning unowned, floating references and with functions returning owned, non-floating references of InitiallyUnowned subclasses. And at the same time keeps constructors for InitiallyUnowned subclasses working correctly without leaks. See https://gitlab.freedesktop.org/gstreamer/gstreamer-sharp/issues/31 |
||
|---|---|---|
| .. | ||
| AtkSharp | ||
| CairoSharp | ||
| GdkSharp | ||
| GioSharp | ||
| GLibSharp | ||
| GtkSharp | ||
| GtkSourceSharp | ||
| PangoSharp | ||
| Shared | ||