From 85b84f99f651f2a640dad0ca62ce986b9bb57aa2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9s=20G=2E=20Aragoneses?= Date: Tue, 8 May 2012 20:35:36 +0100 Subject: [PATCH] glib: Remove redundant call to ToggleRef.QueueUnref() In slow systems this redundant call was causing the following CRITICAL: GLib-GObject-CRITICAL **: g_object_remove_toggle_ref: assertion `G_IS_OBJECT (object)' failed The GLib.Object.Dispose(bool) method already calls this function at the end so there is no need to check for duplicates in the PendingDestroys static field of ToggleRef class (thanks to Alan McGorvern for helping tracking down the root cause), the double unref call is just prevented. Fixes BXC#4909. --- glib/Object.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/glib/Object.cs b/glib/Object.cs index 1cd05830d..64c579092 100644 --- a/glib/Object.cs +++ b/glib/Object.cs @@ -60,7 +60,6 @@ namespace GLib { ToggleRef tref; lock (Objects) { if (Objects.TryGetValue (Handle, out tref)) { - tref.QueueUnref (); Objects.Remove (Handle); } }