ryujinx-archive/GtkSharp
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gui-thread-check: add two more methods to the whitelist

Browse source 
At application shutdown, it's very likely to be spammed by
gui-thread-check with a river of:

*** GTK CALL NOT IN GUI THREAD: Widget.Dispose
*** GTK CALL NOT IN GUI THREAD: Widget.remove_InternalDestroyed
*** GTK CALL NOT IN GUI THREAD: Widget.Dispose
*** GTK CALL NOT IN GUI THREAD: Widget.remove_InternalDestroyed
...

From what I gather, these two methods (in gtk-sharp master[1]) could
be called by the finalizers, but do not call any unmanaged functions,
so it should be ok to not report them as violations.

[1] https://github.com/mono/gtk-sharp/blob/master/gtk/Widget.cs

Cherry-picked from 77a40599ca
This commit is contained in:
Andrés G. Aragoneses 2013-10-31 10:16:14 +01:00
parent 68c64bedc0
commit 7dafb39c01
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
gtk/gui-thread-check/profiler/gui-thread-check.c
View file

@ -72,9 +72,11 @@ simple_method_enter (MonoProfiler *prof, MonoMethod *method)
} }
if (current_thread_id != guithread && if (current_thread_id != guithread &&
!(strcmp (klass_name, "Object")==0 && strcmp (method_name, "Dispose")==0) && !(strcmp (klass_name, "Object")==0 && strcmp (method_name, "Dispose")==0) &&
!(strcmp (klass_name, "Widget")==0 && strcmp (method_name, "Dispose")==0) &&
!(strcmp (klass_name, "Application")==0 && strcmp (method_name, "Invoke")==0) && !(strcmp (klass_name, "Application")==0 && strcmp (method_name, "Invoke")==0) &&
!(strcmp (method_name, "Finalize")==0) && !(strcmp (method_name, "Finalize")==0) &&
!(strcmp (method_name, "get_NativeDestroyHandler")==0) && !(strcmp (method_name, "get_NativeDestroyHandler")==0) &&
!(strcmp (method_name, "remove_InternalDestroyed")==0) &&
!(strcmp (method_name, "remove_Destroyed")==0) !(strcmp (method_name, "remove_Destroyed")==0)
) { ) {
printf ("*** GTK CALL NOT IN GUI THREAD: %s.%s\n", klass_name, method_name); printf ("*** GTK CALL NOT IN GUI THREAD: %s.%s\n", klass_name, method_name);