ryujinx-archive/GtkSharp
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
GtkSharp/HACKING

16 lines
860 B
Text
Raw Normal View History

2001-10-04 Mike Kestner <mkestner@speakeasy.net> * HACKING : Little bit of cleanup. * gdk/SimpleEvent.cs : Redesigned a bit. Docs. Replaced refcounting mechanism with an instance hash and added ctor/dtor. This class now completely encapsulates the signal attachment and forwarding mechanism for GdkEvent based signals. It attaches to the raw signal, maintains a ref to the associated event handler, and uses the static callback to activate the event handler on signal receipt. * sample/makefile : killed one last CSC explicit reference. svn path=/trunk/gtk-sharp/; revision=1076
2001-10-04 19:12:55 +00:00
Before beginning work on something, please post your intentions to the
mailing list (gtk-sharp-list@ximian.com). Duplication of effort just gets
folks cranky in general.
2001-09-19 Mike Kestner <mkestner@speakeasy.net> * HACKING : New rulez. * NOTES: Killed. We have a mailing list now for this kind of stuff. * glib/makefile : New, to build the new glib-sharp.dll target. * glib/Object.cs : (GetObject): Commented out. Design problems here. IntPtr's can't be used in the manner this code attempts to use them. (Data prop): Commented out. Apparently keyed properties are not supported. (Object prop): Renamed RawObject, and made it protected. (Events): Fixed to cause list to be initialized if null and then return the list. * glib/ObjectManager.cs : commented out entirely. Not sure what this code is trying to accomplish and it doesn't compile. * glib/Value.cs : New attempt at implementing GValues. Doesn't work yet. * gtk/Button.cs : Updated to use RawObject. (Clicked event): s/EmitDeleteEvent/EmitClickedEvent. (Button(String)): s/gtk_label_new_with_lable/gtk_button_new_with_label. * gtk/Label.cs : Fixed some yank and paste errors where 2 value params were getting passed to all the set_* property methods. * gtk/Window.cs : Fixed hanging GTK namespace ref. * sample/HelloWorld.cs : Fixed hanging GTK namespace ref. svn path=/trunk/gtk-sharp/; revision=884
2001-09-19 11:37:15 +00:00
Prior to checking anything into CVS, please send a patch to the mailing list
2001-10-04 Mike Kestner <mkestner@speakeasy.net> * HACKING : Little bit of cleanup. * gdk/SimpleEvent.cs : Redesigned a bit. Docs. Replaced refcounting mechanism with an instance hash and added ctor/dtor. This class now completely encapsulates the signal attachment and forwarding mechanism for GdkEvent based signals. It attaches to the raw signal, maintains a ref to the associated event handler, and uses the static callback to activate the event handler on signal receipt. * sample/makefile : killed one last CSC explicit reference. svn path=/trunk/gtk-sharp/; revision=1076
2001-10-04 19:12:55 +00:00
for approval. Any patches should be submitted in diff -u format. Also, it is
assumed that the submitter has verified that the patch does not break the
build, and hopefully that it doesn't break runtime.
2001-09-19 Mike Kestner <mkestner@speakeasy.net> * HACKING : New rulez. * NOTES: Killed. We have a mailing list now for this kind of stuff. * glib/makefile : New, to build the new glib-sharp.dll target. * glib/Object.cs : (GetObject): Commented out. Design problems here. IntPtr's can't be used in the manner this code attempts to use them. (Data prop): Commented out. Apparently keyed properties are not supported. (Object prop): Renamed RawObject, and made it protected. (Events): Fixed to cause list to be initialized if null and then return the list. * glib/ObjectManager.cs : commented out entirely. Not sure what this code is trying to accomplish and it doesn't compile. * glib/Value.cs : New attempt at implementing GValues. Doesn't work yet. * gtk/Button.cs : Updated to use RawObject. (Clicked event): s/EmitDeleteEvent/EmitClickedEvent. (Button(String)): s/gtk_label_new_with_lable/gtk_button_new_with_label. * gtk/Label.cs : Fixed some yank and paste errors where 2 value params were getting passed to all the set_* property methods. * gtk/Window.cs : Fixed hanging GTK namespace ref. * sample/HelloWorld.cs : Fixed hanging GTK namespace ref. svn path=/trunk/gtk-sharp/; revision=884
2001-09-19 11:37:15 +00:00
2001-10-04 Mike Kestner <mkestner@speakeasy.net> * HACKING : Little bit of cleanup. * gdk/SimpleEvent.cs : Redesigned a bit. Docs. Replaced refcounting mechanism with an instance hash and added ctor/dtor. This class now completely encapsulates the signal attachment and forwarding mechanism for GdkEvent based signals. It attaches to the raw signal, maintains a ref to the associated event handler, and uses the static callback to activate the event handler on signal receipt. * sample/makefile : killed one last CSC explicit reference. svn path=/trunk/gtk-sharp/; revision=1076
2001-10-04 19:12:55 +00:00
Patches without Documentation comments will be seriously frowned upon,
2001-09-19 Mike Kestner <mkestner@speakeasy.net> * HACKING : New rulez. * NOTES: Killed. We have a mailing list now for this kind of stuff. * glib/makefile : New, to build the new glib-sharp.dll target. * glib/Object.cs : (GetObject): Commented out. Design problems here. IntPtr's can't be used in the manner this code attempts to use them. (Data prop): Commented out. Apparently keyed properties are not supported. (Object prop): Renamed RawObject, and made it protected. (Events): Fixed to cause list to be initialized if null and then return the list. * glib/ObjectManager.cs : commented out entirely. Not sure what this code is trying to accomplish and it doesn't compile. * glib/Value.cs : New attempt at implementing GValues. Doesn't work yet. * gtk/Button.cs : Updated to use RawObject. (Clicked event): s/EmitDeleteEvent/EmitClickedEvent. (Button(String)): s/gtk_label_new_with_lable/gtk_button_new_with_label. * gtk/Label.cs : Fixed some yank and paste errors where 2 value params were getting passed to all the set_* property methods. * gtk/Window.cs : Fixed hanging GTK namespace ref. * sample/HelloWorld.cs : Fixed hanging GTK namespace ref. svn path=/trunk/gtk-sharp/; revision=884
2001-09-19 11:37:15 +00:00
if not outright rejected. All classes, methods, properties, events, etc...
that are non-private should be documented with XML comment tags. At a minimum,
2001-10-04 Mike Kestner <mkestner@speakeasy.net> * HACKING : Little bit of cleanup. * gdk/SimpleEvent.cs : Redesigned a bit. Docs. Replaced refcounting mechanism with an instance hash and added ctor/dtor. This class now completely encapsulates the signal attachment and forwarding mechanism for GdkEvent based signals. It attaches to the raw signal, maintains a ref to the associated event handler, and uses the static callback to activate the event handler on signal receipt. * sample/makefile : killed one last CSC explicit reference. svn path=/trunk/gtk-sharp/; revision=1076
2001-10-04 19:12:55 +00:00
the summary and remarks tags, plus returns and params, if applicable. Doing
this as we go is the only feasible way to make sure that our docs won't end
up sucking bigtime.
Reference in a new issue Copy permalink