From e46ea31ba5e6e18a8b9c0418784c8d156efb869d Mon Sep 17 00:00:00 2001
From: ferricles <ferricles@gmail.com>
Date: Sun, 22 May 2022 01:10:55 -0700
Subject: [PATCH] refactored changes to more appropriate places

---
 js/sq2bs.js      |  7 +++++++
 js/sq2display.js | 40 +++++-----------------------------------
 2 files changed, 12 insertions(+), 35 deletions(-)

diff --git a/js/sq2bs.js b/js/sq2bs.js
index 25ac2d2..268ca34 100644
--- a/js/sq2bs.js
+++ b/js/sq2bs.js
@@ -236,6 +236,13 @@ function toggle_spell_tab(tab) {
     } else {
         document.querySelector("#"+tab).style.display = "none";
     }
+
+    let arrow_img = document.querySelector("#" + "arrow_" + tab + "Avg");
+    if (arrow_img.src.includes("down")) {
+        arrow_img.src = arrow_img.src.replace("down", "up");
+    } else {
+        arrow_img.src = arrow_img.src.replace("up", "down");
+    }
 }
 
 function toggle_boost_tab(tab) {
diff --git a/js/sq2display.js b/js/sq2display.js
index 7043e8e..4977740 100644
--- a/js/sq2display.js
+++ b/js/sq2display.js
@@ -1413,41 +1413,11 @@ function displaysq2SpellDamage(parent_elem, overallparent_elem, build, spell, sp
     }
 
     //up and down arrow - done ugly
-
-
-
-    let down_arrow = document.createElement("img");
-    down_arrow.id = "down_arrow_" + overallparent_elem.id;
-    down_arrow.style.maxWidth = document.body.clientWidth > 900 ? "3rem" : "10rem";
-    down_arrow.src = "../media/icons/" + (newIcons ? "new" : "old") + "/toggle_down.png";
-    overallparent_elem.appendChild(down_arrow);
-
-    let up_arrow = document.createElement("img");
-    up_arrow.id = "up_arrow_" + overallparent_elem.id;
-    up_arrow.style.maxWidth =  document.body.clientWidth > 900 ? "3rem" : "10rem";
-    up_arrow.src = "../media/icons/" + (newIcons ? "new" : "old") + "/toggle_up.png";
-    up_arrow.style.display = "none";
-    overallparent_elem.appendChild(up_arrow);
-
-    overallparent_elem.setAttribute("onclick", overallparent_elem.getAttribute("onclick") + `;toggleUpDownArrow("${overallparent_elem.id}")`);
-}
-
-function toggleUpDownArrow(parent_id) {
-    parent_elem = document.getElementById(parent_id);
-    if (parent_elem) {
-        let down_arrow = document.getElementById("down_arrow_" + parent_id);
-        if (down_arrow.style.display === "none") {
-            down_arrow.style.display = "";
-        } else {
-            down_arrow.style.display = "none";
-        }
-        let up_arrow = document.getElementById("up_arrow_" + parent_id);
-        if (up_arrow.style.display === "none") {
-            up_arrow.style.display = "";
-        } else {
-            up_arrow.style.display = "none";
-        }
-    }
+    let arrow = document.createElement("img");
+    arrow.id = "arrow_" + overallparent_elem.id;
+    arrow.style.maxWidth = document.body.clientWidth > 900 ? "3rem" : "10rem";
+    arrow.src = "../media/icons/" + (newIcons ? "new" : "old") + "/toggle_down.png";
+    overallparent_elem.appendChild(arrow);
 }
 
 function displaysq2EquipOrder(parent_elem, buildOrder){