endernon/wynnbuilder-forked-for-changes
1
0
Fork 0
forked from morphNon/wynnbuilder-idk
Code Pull requests Activity

Fix unsafe location.hash usage in saveBuild

Browse source
This commit is contained in:
dr-carlos 2021-09-18 06:26:29 +09:30 committed by hppeng-wynn
parent 890b5252f0
commit a42db4128a
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
builder.js
View file

@ -889,14 +889,15 @@ function saveBuild() {
if (player_build) { if (player_build) {
let savedBuilds = window.localStorage.getItem("builds") === null ? {} : JSON.parse(window.localStorage.getItem("builds")); let savedBuilds = window.localStorage.getItem("builds") === null ? {} : JSON.parse(window.localStorage.getItem("builds"));
let saveName = document.getElementById("build-name").value; let saveName = document.getElementById("build-name").value;
if ((!Object.keys(savedBuilds).includes(saveName) || document.getElementById("saved-error").textContent !== "") && location.hash !== "") { let encodedBuild = encodeBuild();
savedBuilds[saveName] = location.hash.replace("#", ""); if ((!Object.keys(savedBuilds).includes(saveName) || document.getElementById("saved-error").textContent !== "") && encodedBuild !== "") {
savedBuilds[saveName] = encodedBuild.replace("#", "");
window.localStorage.setItem("builds", JSON.stringify(savedBuilds)); window.localStorage.setItem("builds", JSON.stringify(savedBuilds));
document.getElementById("saved-error").textContent = ""; document.getElementById("saved-error").textContent = "";
document.getElementById("saved-build").textContent = "Build saved"; document.getElementById("saved-build").textContent = "Build saved";
} else { } else {
if (location.hash === "") if (encodedBuild === "")
document.getElementById("saved-error").textContent = "Empty build"; document.getElementById("saved-error").textContent = "Empty build";
else else
document.getElementById("saved-error").textContent = "Exists. Overwrite?"; document.getElementById("saved-error").textContent = "Exists. Overwrite?";