From 94b67115aa8f7298cec5eba024ce822d771f32a6 Mon Sep 17 00:00:00 2001 From: hppeng Date: Fri, 24 Jun 2022 22:43:28 -0700 Subject: [PATCH] Fix builder throwing error on empty URL TODO: clean up dirty flags --- builder/doc.html | 2 +- js/computation_graph.js | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/builder/doc.html b/builder/doc.html index da5e87a..bfcdf9b 100644 --- a/builder/doc.html +++ b/builder/doc.html @@ -1428,7 +1428,7 @@ -
+
diff --git a/js/computation_graph.js b/js/computation_graph.js index 283f54a..76b1c2d 100644 --- a/js/computation_graph.js +++ b/js/computation_graph.js @@ -93,9 +93,9 @@ class ComputeNode { this.inputs.push(parent_node) link_name = (link_name !== undefined) ? link_name : parent_node.name; this.input_translation.set(parent_node.name, link_name); - this.inputs_dirty.set(parent_node.name, parent_node.dirty); - if (parent_node.dirty) { + if (parent_node.dirty || (parent_node.value === null && !this.fail_cb)) { this.inputs_dirty_count += 1; + this.inputs_dirty.set(parent_node.name, true); } parent_node.children.push(this); return this;